Antti Väyrynen / Moya

Bill rounding

Make product price scale a constant in Bill. We want to calculate all product prices with 4 decimal precision, just in case. And to make a reference quote for future generations: "This should be enough for everyone". We still want to display the price to users with scale 2, but the scaling should be done at the view level, after all calculations have been made.

This commit does not have any functional changes because all data going through database has scale set already to 4. This just makes the value constant and adds some comments to remind that the scale and rounding mode have real world impact..

By default BigDecimal has a huge scale, which causes BigDecimal to act like a float and these become true:

  * new BigDecimal(555.55) -> 555.549999999999954525264911353588104248046875
  * 55554 == new BigDecimal(555.55).multiply(new BigDecimal(100)).intValue();

See merge request !260

Session management fixups

Session management bean gets called every time user enters the page. Collection implementations can handle concurrent read and write access and there is no need for transactions, so there is no need for container managed concurrency and transaction management.

See merge request !259

Minor interface and enum renames and testcase fixing

Test cases need to be renamed consistently to be automatically included with maven testing framework. All unit test classes need to a) start with 'Test', b) end with 'Test' or c) end with 'TestCase' Test classes have been renamed to conform with this requirement.

Change names of Checkout parameter classes to be more descriptive what the classes really are for.

Includes also some unnecessary type checks from checkout QueryBuilder.

See merge request !258

Event creation fixup

These were missing from previous event creation and property editing commit

See merge request !257

…ed to use bean managed

Karttafix

jotain muutoksia karttajutukkeeseen

See merge request !255

 * Rename CheckoutFi parameters more correctly
 * All test classes need to start with Test or end with Test or TestCase
   To be included in maven builds

Checkout.fi payment refactor

Refactor Checkout.fi api requests to allow different queries to checkout api.
This is done to allow creation of bill payment status requests. Api calls exists and all this needs is some ui magick.

also: can has tests \o/

See merge request !256

Eventorg creation and property editing fix

Event was not updated to correct places so that updates to newly created events fail.

Also fix display of newly created properties.
Properties updated values were show only when the event was reloaded.

See merge request !254

Also fix updating event properties on when creating new properties.

Placeslot continue bug

Jos laskun ensimmäinen tuote ei sisällä konepaikkoja, ei luoda millekkään laskun tuotteelle placeslotteja

See merge request !253

Placeslot bug

There is our bug.

Tää mahdollistaa laskunluonnin ilman että saa sen maksaessaan paikkaslotteja. Tarkistus tarttis olla sielä missä laskuun lisätään tuotteet.

See merge request !252

Emptyfix

Check size instead of empty because ListDataModel does not support empty function

See merge request !251

Placeselect

When user is using placeslots (ie. selecting places) and for some reason leaves the page when all placeslots are in use, user can not return to the page to lock the places...

Change logic so that if user has any placeslots (used or not), place selecting page can be entered.

See merge request !250

rest exceptions, etc.

See merge request !249

Mitakakkaa

See merge request !248

…place selection and lock the places

Card print fix

Livin korttipohjakorjaukset

See merge request !247

Infolog fixes

linkki

See merge request !246

Limit number of places an unpaid bill can reserve

Limit the number of placeslots are counted when checking how many places an unpaid bill can reserve. This is done to limit the possibility for abuse by creating a bill with large number of places without any intent for paying it

See merge request !245