Skip to content
  • Projects
  • Groups
  • Snippets
  • Help

Codecrew / Moya

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 30
  • Merge Requests 2
  • Wiki
  • Snippets
  • Settings
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
Merged
Merge Request !429 opened Oct 28, 2018 by Tuomas Riihimäki@tuomari

Add some sanity checks to role fetching.

Just in case, check that all roles returned are from the correct event.

Edited Jan 31, 2019
Request to merge rolecheck into master
×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b rolecheck origin/rolecheck

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout master
git merge --no-ff rolecheck

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Pipeline #164 passed
for 5b6f2c04.
Pipeline #164 passed with warnings
for 5b6f2c04.
Pipeline #164 skipped
for 5b6f2c04.
Pipeline #164 waiting for manual action
for 5b6f2c04.
Pipeline #164 canceled
for 5b6f2c04.
Pipeline #164 failed
for 5b6f2c04.
Pipeline #164 running
for 5b6f2c04.
Pipeline #164 pending
for 5b6f2c04.

Merged

  • The changes were merged into master.
  • Discussion 3
  • Commits 1
  • Pipelines 1
  • Changes 3
  • {{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Jenkins @jenkins commented Oct 28, 2018
    Developer

    Build triggered.

  • Jenkins @jenkins commented Oct 28, 2018
    Developer

    Build Started: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/359/

  • Jenkins @jenkins commented Oct 28, 2018
    Developer

    Build finished. Tests PASSED. Build results available at: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/359/

  • Tuukka Kivilahti @tkfftk

    merged

    Jan 31, 2019

    merged

    Toggle commit list
  • Tuukka Kivilahti @tkfftk

    mentioned in commit 327aa8cc

    Jan 31, 2019

    mentioned in commit 327aa8cc

    Toggle commit list
  • Write
  • Preview
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
  • Please register or sign in to post a comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
3
3 participants
Reference: codecrew/moya!429
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.