Skip to content
  • Projects
  • Groups
  • Snippets
  • Help

Codecrew / Moya

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 30
  • Merge Requests 2
  • Wiki
  • Snippets
  • Settings
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
Merged
Merge Request !416 opened Aug 07, 2018 by Tuukka Kivilahti@tkfftk

Graphql backend fixes and Apollo graphql -api for frontend

Backend now follows graphql specification.

  • HTTP Return code tells if there was problem with http protocol stuff
  • GraphQL error's thells if there was problems with GraphQL -query itself (but http returncode is still 200)
  • UTF-8 is our friend
  • In theory, it also now support's variables, it's not tested yet

Apollo graphql frontend.

Edited Sep 21, 2018
Request to merge tkfftk:graphql-for-frontend into master
×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.codecrew.fi/tkfftk/moya.git graphql-for-frontend
git checkout -b tkfftk/moya-graphql-for-frontend FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout master
git merge --no-ff tkfftk/moya-graphql-for-frontend

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Merged

  • The changes were merged into master.
  • Discussion 17
  • Commits 9
  • Changes 27
  • {{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Jenkins @jenkins commented Aug 07, 2018
    Developer

    Build triggered.

  • Jenkins @jenkins commented Aug 07, 2018
    Developer

    Build Started: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/299/

  • Jenkins @jenkins commented Aug 07, 2018
    Developer

    Build finished. Tests FAILED. Build results available at: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/299/

  • Jenkins @jenkins commented Aug 08, 2018
    Developer

    Build Started: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/300/

  • Jenkins @jenkins commented Aug 08, 2018
    Developer

    Build finished. Tests FAILED. Build results available at: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/300/

  • Avatar
    Aino Leppänen
    @onja started a discussion on an outdated diff Aug 08, 2018
    code/moya-angular/src/app/modules/viplist/viplist.service.ts
    11 10
    12 11
    13 12 import {HttpClient} from '@angular/common/http';
    14 import {MOYA_BASE_URL} from '../../shared/tools/moya-rest.tool';
    13 import {MOYA_BASE_URL, MOYA_REST_URL} from '../../shared/config/moya.config';
    14 import gql from 'graphql-tag';
    15 import {EventUser} from '../../shared/models/event-user.model';
    16 import {Apollo} from 'apollo-angular';
    17 import 'rxjs-compat/add/operator/map';
    • Aino Leppänen @onja commented Aug 08, 2018
      Master

      rxjs-compat was removed in master

  • Jenkins @jenkins commented Aug 08, 2018
    Developer

    Build Started: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/301/

  • Jenkins @jenkins commented Aug 08, 2018
    Developer

    Build finished. Tests FAILED. Build results available at: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/301/

  • Avatar
    Aino Leppänen
    @onja started a discussion on an outdated diff Aug 08, 2018
    code/moya-angular/src/app/modules/viplist/viplist.service.ts
    23 67
    24 68 /**
    25 69 * get vips
    26 * @param searchString: searchString, skip to return all vips
    27 70 */
    28 public get(searchString?: string): Observable<Array<Vip>> {
    29
    30 if (!searchString) {
    31 return this.http.get(MOYA_BASE_URL + 'v3/vip/all').pipe(
    32 switchMap(res => observableForkJoin(...(res as Array<any>), map(apiRow => this.hostPopulator(apiRow)))));
    33 }
    34
    35 return this.http.get(MOYA_BASE_URL + 'v3/vip/search/' + searchString).pipe(
    36 switchMap(v => observableForkJoin(...(v as Array<any>), map(x => this.hostPopulator(x)))));
    71 public get(): Observable<Array<Vip>> {
    72 return this.apollo.watchQuery<VipsQueryRoot>({query: Q_VIPS_N_DATA}).valueChanges.pipe(map(x => { console.log(x.data.vips); return x.data.vips; }));
    • Aino Leppänen @onja commented Aug 08, 2018
      Master

      Rm console log

  • Tuukka Kivilahti @tkfftk

    added 1 commit

    • 7d108edd - comments from merge request

    Compare with previous version

    Aug 08, 2018

    added 1 commit

    • 7d108edd - comments from merge request

    Compare with previous version

    Toggle commit list
  • Jenkins @jenkins commented Aug 08, 2018
    Developer

    Build triggered.

  • Jenkins @jenkins commented Aug 08, 2018
    Developer

    Build Started: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/302/

  • Jenkins @jenkins commented Aug 08, 2018
    Developer

    Build finished. Tests FAILED. Build results available at: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/302/

  • Jenkins @jenkins commented Aug 08, 2018
    Developer

    Build Started: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/303/

  • Jenkins @jenkins commented Aug 08, 2018
    Developer

    Build finished. Tests FAILED. Build results available at: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/303/

  • Jenkins @jenkins commented Aug 09, 2018
    Developer

    Build Started: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/304/

  • Jenkins @jenkins commented Aug 09, 2018
    Developer

    Build finished. Tests FAILED. Build results available at: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/304/

  • Tuomas Riihimäki @tuomari commented Aug 09, 2018
    Owner

    test this please

  • Tuomas Riihimäki @tuomari

    merged

    Sep 21, 2018

    merged

    Toggle commit list
  • Tuomas Riihimäki @tuomari

    mentioned in commit 593ea1d2

    Sep 21, 2018

    mentioned in commit 593ea1d2

    Toggle commit list
  • Write
  • Preview
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
  • Please register or sign in to post a comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
4
4 participants
Reference: codecrew/moya!416
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.