Skip to content
  • Projects
  • Groups
  • Snippets
  • Help

Codecrew / Moya

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 30
  • Merge Requests 2
  • Wiki
  • Snippets
  • Settings
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
Merged
Merge Request !402 opened Apr 02, 2018 by Tuukka Kivilahti@tkfftk

Feature/folder structure

Edited Aug 03, 2018
Request to merge feature/folderStructure into master
×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feature/folderStructure origin/feature/folderStructure

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout master
git merge --no-ff feature/folderStructure

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Pipeline #75 passed
for bf3930a4.
Pipeline #75 passed with warnings
for bf3930a4.
Pipeline #75 skipped
for bf3930a4.
Pipeline #75 waiting for manual action
for bf3930a4.
Pipeline #75 canceled
for bf3930a4.
Pipeline #75 failed
for bf3930a4.
Pipeline #75 running
for bf3930a4.
Pipeline #75 pending
for bf3930a4.

Merged

  • The changes were merged into master.
  • Discussion 30
  • Commits 32
  • Pipelines 8
  • Changes 154
  • {{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Jenkins @jenkins commented Apr 02, 2018
    Developer

    Build triggered.

  • Jenkins @jenkins commented Apr 02, 2018
    Developer

    Build Started: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/192/

  • Jenkins @jenkins commented Apr 02, 2018
    Developer

    Build finished. Tests FAILED. Build results available at: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/192/

  • Aino Leppänen @onja

    added 1 commit

    • dccd3046 - routing

    Compare with previous version

    Apr 02, 2018

    added 1 commit

    • dccd3046 - routing

    Compare with previous version

    Toggle commit list
  • Jenkins @jenkins commented Apr 02, 2018
    Developer

    Build triggered.

  • Jenkins @jenkins commented Apr 02, 2018
    Developer

    Build Started: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/195/

  • Jenkins @jenkins commented Apr 02, 2018
    Developer

    Build finished. Tests FAILED. Build results available at: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/195/

  • Tuukka Kivilahti @tkfftk

    added 5 commits

    • 4adb2c33 - not yet ready
    • 0ecc70c5 - Merge branch 'feature/folderStructure' of gitlab.codecrew.fi:codecrew/moya into …
    • e94a1056 - now it should work ,commit before logs
    • 16d94af2 - logging
    • 802f81a1 - now menu works

    Compare with previous version

    Apr 02, 2018

    added 5 commits

    • 4adb2c33 - not yet ready
    • 0ecc70c5 - Merge branch 'feature/folderStructure' of gitlab.codecrew.fi:codecrew/moya into …
    • e94a1056 - now it should work ,commit before logs
    • 16d94af2 - logging
    • 802f81a1 - now menu works

    Compare with previous version

    Toggle commit list
  • Jenkins @jenkins commented Apr 02, 2018
    Developer

    Build triggered.

  • Jenkins @jenkins commented Apr 02, 2018
    Developer

    Build Started: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/223/

  • Jenkins @jenkins commented Apr 02, 2018
    Developer

    Build finished. Tests FAILED. Build results available at: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/223/

  • Tuukka Kivilahti @tkfftk

    added 1 commit

    • dceaf3c3 - this maybe fixes something

    Compare with previous version

    Apr 02, 2018

    added 1 commit

    • dceaf3c3 - this maybe fixes something

    Compare with previous version

    Toggle commit list
  • Jenkins @jenkins commented Apr 02, 2018
    Developer

    Build triggered.

  • Jenkins @jenkins commented Apr 02, 2018
    Developer

    Build Started: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/226/

  • Jenkins @jenkins commented Apr 02, 2018
    Developer

    Build finished. Tests FAILED. Build results available at: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/226/

  • Tuukka Kivilahti @tkfftk

    added 1 commit

    • 2374f975 - lintter

    Compare with previous version

    Apr 02, 2018

    added 1 commit

    • 2374f975 - lintter

    Compare with previous version

    Toggle commit list
  • Jenkins @jenkins commented Apr 02, 2018
    Developer

    Build triggered.

  • Jenkins @jenkins commented Apr 02, 2018
    Developer

    Build Started: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/228/

  • Jenkins @jenkins commented Apr 02, 2018
    Developer

    Build finished. Tests FAILED. Build results available at: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/228/

  • Tuukka Kivilahti @tkfftk

    added 2 commits

    • 3012b2dc - removed obsolute menucomponents
    • 617ab770 - viplist is now lazyloaded thingy

    Compare with previous version

    Apr 03, 2018

    added 2 commits

    • 3012b2dc - removed obsolute menucomponents
    • 617ab770 - viplist is now lazyloaded thingy

    Compare with previous version

    Toggle commit list
  • Jenkins @jenkins commented Apr 03, 2018
    Developer

    Build triggered.

  • Jenkins @jenkins commented Apr 03, 2018
    Developer

    Build Started: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/234/

  • Jenkins @jenkins commented Apr 03, 2018
    Developer

    Build finished. Tests FAILED. Build results available at: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/234/

  • Tuukka Kivilahti @tkfftk

    unmarked as a Work In Progress

    Aug 03, 2018

    unmarked as a Work In Progress

    Toggle commit list
  • Avatar
    Aino Leppänen
    @onja started a discussion on an outdated diff Aug 03, 2018
    code/moya-angular/src/app/app-routing.module.ts
    4 import { LoginComponent } from './pages/login/login.component';
    5 import { InfoComponent } from './pages/info/info.component';
    2 import {Routes, RouterModule, PreloadAllModules, NoPreloading} from '@angular/router';
    3 import { LoginComponent } from './modules/login/login.component';
    4 import {FrontpageComponent} from './components/frontpage/frontpage.component';
    6 5
    7 6 const APP_ROUTES: Routes = [
    8 { path: 'info', loadChildren: 'app/pages/info/info.module#InfoModule' },
    9 { path: 'admin', loadChildren: 'app/pages/admin/admin.module#AdminModule' },
    10 { path: 'user', loadChildren: 'app/pages/user/user.module#UserModule' },
    11 7 { path: 'login', component: LoginComponent },
    12 { path: '', pathMatch: 'full', redirectTo: 'login' },
    13 { path: '**', component: LoginComponent }
    14 ];
    8 { path: 'viplist', loadChildren: 'app/modules/viplist/viplist.module#ViplistModule' },
    9 /*{ path: 'viplist', component: InfoViplistPageComponent },*/
    • Aino Leppänen @onja commented Aug 03, 2018
      Master

      remove comments

  • Avatar
    Aino Leppänen
    @onja started a discussion on an outdated diff Aug 03, 2018
    code/moya-angular/src/app/components/moya-locale/moya-locale.component.ts
    17 12 svSelected = true;
    18 13 enSelected = true;
    19 14
    20 constructor(private localeService: MoyaLocaleService, private translate: TranslateService) {
    21 // fallback language
    22 translate.setDefaultLang(DEFAULT_LOCALE);
    23 this.selectLocale(DEFAULT_LOCALE);
    24 }
    15 constructor(private localeService: MoyaLocaleService) { }
    • Aino Leppänen @onja commented Aug 03, 2018
      Master

      No need to prefix services

  • Avatar
    Aino Leppänen
    @onja started a discussion on an outdated diff Aug 03, 2018
    Resolved by Aino Leppänen Aug 03, 2018
    code/moya-angular/src/app/components/moya-locale/moya-locale.service.ts
    14 export const DEFAULT_LOCALE = FINNISH;
    9 15 const LOCALSTORAGE_NAME = 'currently used locale code';
    10 16
    17
    18
    19
    20
    11 21 @Injectable()
    12 22 export class MoyaLocaleService {
    13 constructor(private http: HttpClient) { }
    23
    24 selectedLocale: string;
    25
    26 constructor(private http: HttpClient, private translate: TranslateService) {
    27
    28 // Falback to be something what everyone can read
    • Aino Leppänen @onja commented Aug 03, 2018
      Master

      Set default language

  • Avatar
    Aino Leppänen
    @onja started a discussion on an outdated diff Aug 03, 2018
    Resolved by Aino Leppänen Aug 03, 2018
    code/moya-angular/src/app/menu/defines/menu.ts
    29 36 'items': [
    30 { 'path': '/user/old', 'name': 'Poll', 'params': {p: 'poll/index.jsf'} },
    31 { 'path': '/user/old', 'name': 'Invite friends', 'params': {p: 'user/invite.jsf'} },
    37 { 'path': '/old/user', 'name': 'Poll', 'params': {p: 'poll/index.jsf'} },
    38 { 'path': '/old/user', 'name': 'Invite friends', 'params': {p: 'user/invite.jsf'} },
    32 39 ]},
    33 40 {
    34 41 'name': 'Shop',
    35 42 'items': [
    36 { 'path': '/user/old', 'name': 'Buy Tickets', 'params': {p: 'shop/createBill.jsf'} },
    37 { 'path': '/user/old', 'name': 'Reserve Places', 'params': {p: 'neomap/reserve.jsf'} },
    38 { 'path': '/user/old', 'name': 'Change Places', 'params': {p: 'neomap/moveplaces.jsf'} },
    39 { 'path': '/user/old', 'name': 'Food Orders', 'params': {p: 'foodwave/list.jsf'} },
    40 { 'path': '/user/old', 'name': 'Own Orders', 'params': {p: 'bill/list.jsf'} },
    41 { 'path': '/user/old', 'name': 'Account Events', 'params': {p: 'user/accountEvents.jsf'} },
    43 { 'path': '/old/user', 'name': 'Buy Tickets', 'params': {p: 'shop/createBill.jsf'} },
    • Aino Leppänen @onja commented Aug 03, 2018
      Master

      Use child routes

  • Avatar
    Aino Leppänen
    @onja started a discussion on an outdated diff Aug 03, 2018
    Resolved by Aino Leppänen Aug 03, 2018
    code/moya-angular/src/app/menu/defines/menu.ts
    24 { 'path': '/viplist/info', 'name': 'VipList'}
    23 25 ]}
    24 26 ];
    25 27
    26 28 static USER: MenuGroup[] = [
    27 29 {
    30 'name': '',
    31 'items': [
    32 { 'path': '/index', 'name': 'Frontpage' },
    33 ]},
    34 {
    28 35 'name': 'Event',
    29 36 'items': [
    30 { 'path': '/user/old', 'name': 'Poll', 'params': {p: 'poll/index.jsf'} },
    31 { 'path': '/user/old', 'name': 'Invite friends', 'params': {p: 'user/invite.jsf'} },
    37 { 'path': '/old/user', 'name': 'Poll', 'params': {p: 'poll/index.jsf'} },
    • Aino Leppänen @onja commented Aug 03, 2018
      Master

      Use child routes

  • Avatar
    Aino Leppänen
    @onja started a discussion on an outdated diff Aug 03, 2018
    code/moya-angular/src/app/menu/left-menu/left-menu.component.ts
    46 this.activateInfo();
    47 return;
    48 }
    49
    50 if (this.searchPath(revent.url, MENU.ADMIN)) {
    51 this.activateAdmin();
    52 return;
    53 }
    54
    55 });
    18 56
    19 57 }
    20 58
    59
    60
    21 61 ngOnInit() {
    • Aino Leppänen @onja commented Aug 03, 2018
      Master

      Rm implement if it doesn't do anything

  • Tuukka Kivilahti @tkfftk

    added 36 commits

    • 617ab770...3dd8641b - 21 commits from branch master
    • 88d3085b - Merge remote-tracking branch 'origin/master' into feature/folderStructure
    • c3cf8a7b - Merge branches 'findbugs-fixes' and 'maven-fix' into massmerge4
    • 67b43f5f - Update swagger version from 1.5 to 2.0
    • f22c63df - WIP: Users eventproperties
    • 42d57068 - Fix logging in with invalid password, and other ui error handlings
    • db4acc8b - Initial graphql api implementation
    • 2b19d7ba - User preference fixes
    • 8930f7aa - Refactor and fix user searching with role.
    • bf475dd2 - Deploy-commit
    • 9413f107 - localization for folderstructure
    • 4f41f41a - Merge remote-tracking branch 'origin/master' into feature/folderStructure
    • fa09aba0 - Merge remote-tracking branch 'origin/deploy-2018-07-27' into feature/folderStructure
    • a8e0ae8c - Some new documentation
    • cdf83bdf - comments fixed
    • 9440bdd8 - merge request fixes

    Compare with previous version

    Aug 03, 2018

    added 36 commits

    • 617ab770...3dd8641b - 21 commits from branch master
    • 88d3085b - Merge remote-tracking branch 'origin/master' into feature/folderStructure
    • c3cf8a7b - Merge branches 'findbugs-fixes' and 'maven-fix' into massmerge4
    • 67b43f5f - Update swagger version from 1.5 to 2.0
    • f22c63df - WIP: Users eventproperties
    • 42d57068 - Fix logging in with invalid password, and other ui error handlings
    • db4acc8b - Initial graphql api implementation
    • 2b19d7ba - User preference fixes
    • 8930f7aa - Refactor and fix user searching with role.
    • bf475dd2 - Deploy-commit
    • 9413f107 - localization for folderstructure
    • 4f41f41a - Merge remote-tracking branch 'origin/master' into feature/folderStructure
    • fa09aba0 - Merge remote-tracking branch 'origin/deploy-2018-07-27' into feature/folderStructure
    • a8e0ae8c - Some new documentation
    • cdf83bdf - comments fixed
    • 9440bdd8 - merge request fixes

    Compare with previous version

    Toggle commit list
  • Tuukka Kivilahti @tkfftk

    marked as a Work In Progress from f22c63df

    Aug 03, 2018

    marked as a Work In Progress from f22c63df

    Toggle commit list
  • Tuukka Kivilahti @tkfftk

    unmarked as a Work In Progress

    Aug 03, 2018

    unmarked as a Work In Progress

    Toggle commit list
  • Jenkins @jenkins commented Aug 03, 2018
    Developer

    Build triggered.

  • Jenkins @jenkins commented Aug 03, 2018
    Developer

    Build Started: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/279/

  • Aino Leppänen @onja

    enabled an automatic merge when the pipeline for 9440bdd8 succeeds

    Aug 03, 2018

    enabled an automatic merge when the pipeline for 9440bdd8 succeeds

    Toggle commit list
  • Jenkins @jenkins commented Aug 03, 2018
    Developer

    Build finished. Tests FAILED. Build results available at: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/279/

  • Tuukka Kivilahti @tkfftk

    added 1 commit

    • bf3930a4 - apollo came in accidentally, now it's not

    Compare with previous version

    Aug 03, 2018

    added 1 commit

    • bf3930a4 - apollo came in accidentally, now it's not

    Compare with previous version

    Toggle commit list
  • Jenkins @jenkins commented Aug 03, 2018
    Developer

    Build triggered.

  • Jenkins @jenkins commented Aug 03, 2018
    Developer

    Build Started: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/281/

  • Jenkins @jenkins commented Aug 03, 2018
    Developer

    Build finished. Tests PASSED. Build results available at: https://jenkins.codecrew.fi/job/Moya/job/moya-mergerequests/281/

  • Aino Leppänen @onja

    mentioned in commit 57efe091

    Aug 03, 2018

    mentioned in commit 57efe091

    Toggle commit list
  • Aino Leppänen @onja

    merged

    Aug 03, 2018

    merged

    Toggle commit list
  • Write
  • Preview
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
  • Please register or sign in to post a comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
3
3 participants
Reference: codecrew/moya!402
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.