Skip to content
  • Projects
  • Groups
  • Snippets
  • Help

Codecrew / Moya

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 30
  • Merge Requests 2
  • Wiki
  • Snippets
  • Settings
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
Merged
Merge Request !287 opened Jun 03, 2015 by Juho Juopperi@jkj

Vectorama2015 REST API - Registration kiosks

Required to get registration kiosks going

Edited Jun 04, 2015
Request to merge jkj:feature/vectorama2015-restapi into master
×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.codecrew.fi/jkj/moya.git feature/vectorama2015-restapi
git checkout -b jkj/moya-feature/vectorama2015-restapi FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout master
git merge --no-ff jkj/moya-feature/vectorama2015-restapi

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Merged

  • The changes were merged into master.
  • Discussion 2
  • Commits 11
  • Changes 14
  • {{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Juho Juopperi @jkj

    Added 1 new commit:

    • ae3b0ab6 - undo some changes that were made elsewhere
    Jun 03, 2015

    Added 1 new commit:

    • ae3b0ab6 - undo some changes that were made elsewhere
    Toggle commit list
  • 2a54e04ac87f85d4d091c3be1c8f9cea?s=80&d=identicon
    Tuukka Kivilahti
    @tkfftk started a discussion on the diff Jun 04, 2015
    code/moya-web/src/main/java/fi/codecrew/moya/rest/v2/UserRestViewV2.java 0 → 100644
    45 EventBeanLocal eventBean;
    46 @EJB
    47 PermissionBeanLocal permissionBean;
    48 @EJB
    49 UserBeanLocal userBean;
    50 @Inject
    51 PojoFactoryV2 pojoFactory;
    52
    53 @GET
    54 @Path("/")
    55 @Produces(MediaType.APPLICATION_JSON)
    56 @ApiOperation(value = "Find user", response = UserPojo.class)
    57 public Response getEventUser(@QueryParam("email") @ApiParam("Email address") String email,
    58 @QueryParam("login") @ApiParam("Username") String userName) {
    59 try {
    60 if (permissionBean.hasPermission(UserPermission.VIEW_ALL) == false) {
    • Tuukka Kivilahti @tkfftk commented Jun 04, 2015
      Owner

      miksi == false eikä esim. !..., tai vaikkapa != !false :P

  • 2a54e04ac87f85d4d091c3be1c8f9cea?s=80&d=identicon
    Tuukka Kivilahti
    @tkfftk started a discussion on the diff Jun 04, 2015
    code/moya-web/src/main/java/fi/codecrew/moya/rest/v2/UserRestViewV2.java 0 → 100644
    92 }
    93
    94 try {
    95 EventUser eventUser = new EventUser(new User(), eventBean.getCurrentEvent(), permissionBean.getCurrentUser());
    96 eventUser.setNick(userPojo.nick);
    97 eventUser.setLogin(userPojo.login);
    98 eventUser.setFirstnames(userPojo.firstname);
    99 eventUser.setLastname(userPojo.lastname);
    100 eventUser.setBirthday(userPojo.birthday);
    101 if (userPojo.gender == UserPojo.UserGender.MALE) {
    102 eventUser.setGender(Gender.MALE);
    103 } else if (userPojo.gender == UserPojo.UserGender.FEMALE) {
    104 eventUser.setGender(Gender.FEMALE);
    105 } else {
    106 eventUser.setGender(Gender.UNDEFINED);
    107 }
    • Tuukka Kivilahti @tkfftk commented Jun 04, 2015
      Owner

      Nää vois tehä kans UserPojo.UserGenderin alle, niin ei ois ihan niin copypaste -fiilis :P

  • Tuukka Kivilahti @tkfftk

    Status changed to merged

    Jun 04, 2015

    Status changed to merged

    Toggle commit list
  • Tuukka Kivilahti @tkfftk

    mentioned in commit a62bd764

    Jun 04, 2015

    mentioned in commit a62bd764

    Toggle commit list
  • Write
  • Preview
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
  • Please register or sign in to post a comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
2
2 participants
Reference: codecrew/moya!287